refactor(model): remove default 'id' from dbIgnoreSave list

src/Libs/Model.php

@@ -23,11 +23,6 @@ use ReflectionProperty;
 #[AllowDynamicProperties]
 class Model
 {
-    /**
-     * @var array Attributes that should be set to NULL on update.
-     */
-    protected array $dbSetToNull = [];
-
     /**
      * @var string The name of the primary key column.
      */
@@ -36,7 +31,7 @@ class Model
     /**
      * @var array Attributes to ignore when saving to the database.
      */
-    protected static array $dbIgnoreSave = ['id'];
+    protected static array $dbIgnoreSave = [];
 
     /**
      * @var array Attributes that should be explicitly saved, even if private/protected.
@@ -161,7 +156,19 @@ class Model
 
         try {
             $prepared = $db->prepare($query);
-            $prepared->execute(static::$dbQueryVariables);
+            foreach (static::$dbQueryVariables as $key => $value) {
+                // Detect data type to choose the PDO constant
+                $type = match (gettype($value)) {
+                    'integer' => PDO::PARAM_INT,
+                    'boolean' => PDO::PARAM_BOOL,
+                    'NULL'    => PDO::PARAM_NULL,
+                    default   => PDO::PARAM_STR,
+                };
+
+                $prepared->bindValue($key, $value, $type);
+            }
+
+            $prepared->execute();
         } catch (PDOException $e) {
             if ($db->inTransaction()) {
                 $db->rollBack();
@@ -289,29 +296,20 @@ class Model
      */
     protected static function getInstance(array $elem = []): static
     {
-        $class         = get_called_class();
-        $instance      = new $class();
-        $reflection    = new ReflectionClass($instance);
-        $properties    = $reflection->getProperties();
-        $propertyNames = array_map(function ($property) {
-            return static::camelCaseToSnakeCase($property->name);
-        }, $properties);
+        $class      = get_called_class();
+        $instance   = new $class();
+        $reflection = new ReflectionClass($instance);
+        $properties = $reflection->getProperties();
+
+        $map = [];
+        foreach ($properties as $prop) {
+            $map[static::camelCaseToSnakeCase($prop->name)] = $prop;
+        }
 
         foreach ($elem as $key => $value) {
-            $index = array_search($key, $propertyNames);
-            if (is_numeric($index)) {
-                $type = $properties[$index]->getType();
-                if (enum_exists($type->getName())) {
-                    if (method_exists($type->getName(), 'tryFrom')) {
-                        $instance->{$properties[$index]->name} = $type->getName()::tryfrom($value);
-                    } elseif (
-                        in_array($value, array_column($type->getName()::cases(), 'name'))
-                    ) {
-                        $instance->{$properties[$index]->name} = $type->getName()::{$value};
-                    }
-                } else {
-                    $instance->{$properties[$index]->name} =  $value;
-                }
+            if (isset($map[$key])) {
+                $property = $map[$key];
+                $instance->{$property->name} = static::castValue($property, $value);
             } else {
                 $instance->{static::snakeCaseToCamelCase($key)} = $value;
             }
@@ -322,6 +320,41 @@ class Model
         return $instance;
     }
 
+    /**
+     * Handles type casting for properties
+     *
+     * @param ReflectionProperty $property
+     * @param mixed              $value
+     *
+     * @return mixed
+     */
+    protected static function castValue(ReflectionProperty $property, mixed $value): mixed
+    {
+        $type = $property->getType();
+        if (!$type) {
+            return $value;
+        }
+
+        $typeName = $type->getName();
+
+        // Enum cast
+        if (enum_exists($typeName)) {
+            if (method_exists($typeName, 'tryFrom')) {
+                return $typeName::tryFrom($value);
+            }
+            if (in_array($value, array_column($typeName::cases(), 'name'))) {
+                return $typeName::{$value};
+            }
+        }
+
+        // DateTime cast
+        if (is_subclass_of($typeName, \DateTimeInterface::class)) {
+            return $value ? new $typeName($value) : null;
+        }
+
+        return $value;
+    }
+
     /**
      * Returns the attributes to be saved for the current class.
      * Attributes will be those that are public and not excluded in static::$ignoreSave,
@@ -337,30 +370,43 @@ class Model
         $result     = [];
 
         foreach ($properties as $property) {
+            // Avoid save unset variables
+            if ($property->getType() && !$property->isInitialized($this)) {
+                continue;
+            }
+
             if (!in_array($property->name, static::$dbIgnoreSave)) {
-                $result[$this->camelCaseToSnakeCase($property->name)] = isset($this->{$property->name})
-                    ? $this->{$property->name} : null;
+                $name = $this->camelCaseToSnakeCase($property->name);
+                $result[$name] = $this->castToDbValue($this->{$property->name});
             }
         }
 
         foreach (static::$dbForceSave as $value) {
-            $result[$value] = isset($this->$value)
-                ? $this->$value : null;
-        }
-
-        foreach ($result as $i => $property) {
-            if (gettype($property) == 'boolean') {
-                $result[$i] = $property ? '1' : '0';
-            }
-
-            if ($property instanceof \UnitEnum) {
-                $result[$i] = $property->value ?? $property->name;
-            }
+            $result[$value] = $this->castToDbValue($this->$value);
         }
 
         return $result;
     }
 
+    /**
+     * Converts a PHP value to a database-compatible value.
+     *
+     * @param  mixed $value
+     * @return mixed
+     */
+    protected function castToDbValue(mixed $value): mixed
+    {
+        if ($value instanceof \UnitEnum) {
+            return $value->value ?? $value->name;
+        }
+
+        if ($value instanceof \DateTimeInterface) {
+            return $value->format('Y-m-d H:i:s');
+        }
+
+        return $value;
+    }
+
     /**
      * Returns the name of the current class, even if it's an extended class.
      *
@@ -432,25 +478,18 @@ class Model
         $atts = $this->getVars();
         static::$dbQueryVariables = [];
 
+        $set = [];
         foreach ($atts as $key => $value) {
-            if (isset($value)) {
-                if (in_array($key, $this->dbSetToNull)) {
-                    $set[] = "$key=NULL";
-                } else {
-                    $set[] = "$key=:$key";
-                    static::$dbQueryVariables[':' . $key] = $value;
-                }
-            } else {
-                if (in_array($key, $this->dbSetToNull)) {
-                    $set[] = "$key=NULL";
-                }
-            }
+            $set[] = "$key=:$key";
+            static::$dbQueryVariables[':' . $key] = $value;
         }
 
         $table = static::table();
         $pk = static::$dbPrimaryKey;
         $pkv = $this->$pk;
-        $sql = "UPDATE $table SET " . join(', ', $set) . " WHERE $pk='$pkv'";
+        $sql = "UPDATE $table SET " . join(', ', $set) . " WHERE $pk=:$pk";
+        static::$dbQueryVariables[":$pk"] = $pkv;
+
         static::query($sql);
     }
 
@@ -468,11 +507,9 @@ class Model
         static::$dbQueryVariables = [];
 
         foreach ($atts as $key => $value) {
-            if (isset($value)) {
-                $into[] = "$key";
-                $values[] = ":$key";
-                static::$dbQueryVariables[":$key"] = $value;
-            }
+            $into[] = "$key";
+            $values[] = ":$key";
+            static::$dbQueryVariables[":$key"] = $value;
         }
 
         $table = static::table();
@@ -480,7 +517,7 @@ class Model
         static::query($sql);
 
         $pk = static::$dbPrimaryKey;
-        $this->$pk = $db->lastInsertId();
+        $this->$pk ??= $db->lastInsertId();
         $this->markAsSaved();
     }
 
@@ -1145,22 +1182,4 @@ class Model
 
         return $instances;
     }
-
-    /**
-     * Allows defining an attribute's value as null.
-     * Only works for updating an element in the DB, not for inserting.
-     *
-     * @param array $attributes
-     *                          Attribute or array of attributes that will be set to null.
-     *
-     * @return void
-     */
-    public function setNull(string ...$attributes): void
-    {
-        foreach ($attributes as $att) {
-            if (!in_array($att, $this->dbSetToNull)) {
-                $this->dbSetToNull[] = $att;
-            }
-        }
-    }
 }