kj/duckbrain
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix(di): Improve parameter resolution and validation

Browse Source
This commit is contained in:
kj
2025-10-10 19:15:07 -03:00
parent a1a15f492c
commit b41514a491
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Libs/Synapsis.php
View File

@@ -118,7 +118,7 @@ class Synapsis
$reflectionClass = new ReflectionClass($className); $reflectionClass = new ReflectionClass($className);
$constructor = $reflectionClass->getConstructor(); $constructor = $reflectionClass->getConstructor();
static::$instances[$className] = new $className( static::$instances[$className] = new $className(
...static::resolveParameterValues($constructor->getParameters()) ...static::resolveParameterValues($constructor?->getParameters() ?? [])
); );
} }
@@ -141,13 +141,17 @@ class Synapsis
continue; continue;
} }
// Intentamos darle un valor equivalente a nulo si es una clase primitiva pare evitar $paramType = $parameter->getType();
// errores innecesarios, lo if ($paramType === null) {
if ($parameter->getType()->isBuiltin()) { // If no type is declared, and it's not optional, we cannot resolve it.
throw new Exception('Primitive parameters expect at least a default value.'); throw new Exception('Untyped parameters expect at least a default value or must be optional.');
} }
$values[] = static::resolveInstance($parameter->getType()->getName()); if ($paramType->isBuiltin()) {
throw new Exception("Primitive parameter '{$parameter->getName()}' expects at least a default value.");
}
$values[] = static::resolveInstance($paramType->getName());
} }
return $values; return $values;
} }